Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Providers_model.php #1529

Closed
wants to merge 1 commit into from
Closed

Conversation

tm8544
Copy link

@tm8544 tm8544 commented May 14, 2024

To handle deprecations on lines 527 and 529.
strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated
When there is a full-day exception, $working_plan_exception['start'] and $working_plan_exception['end'] are both null

This is an issue that came up on #1497 and at some point it seemed to be cleared, so I closed #1497.
Now it is back, and now I can explain more precisely the conditions it occurs.

First of all it is not an exception but a deprecation, but if handled now there would be no exceptions later on with future php versions.

This appears under the following conditions:

  1. in config.php there is const DEBUG_MODE = true; and
  2. error_reporting in php.ini has been set to report deprecations.

Maybe this is the reason you did not see this. In my case both conditions were met.

To handle deprecation on lines 527 and 529
@alextselegidis
Copy link
Owner

Hello!

Thanks for this PR.

I see the problem but it looks like this one requires some additional handling.

I will take a closer look.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

alextselegidis added a commit that referenced this pull request May 21, 2024
@alextselegidis
Copy link
Owner

Added check for this case

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

tm8544 added a commit to tm8544/easyappointments that referenced this pull request May 21, 2024
@tm8544 tm8544 deleted the patch-4 branch May 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants