-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove info log showing Slf4jLogger started to avoid slf4j warning at the top #31395 #32039
base: main
Are you sure you want to change the base?
Conversation
Hi @patriknw , I updated the pr, do you think we also need to un-extend Slf4jLogger with SLF4JLogging? |
@@ -104,7 +104,6 @@ class Slf4jLogger extends Actor with SLF4JLogging with RequiresMessageQueue[Logg | |||
} | |||
|
|||
case InitializeLogger(_) => | |||
log.info("Slf4jLogger started") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should anyway touch the log
because that is a lazy val
and if we don't touch it we haven't really started the intiialization yet, and next real log message will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about let Slf4jLogger
NOT to extend SLF4JLogging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be fine, but it would still have to create the logger at some point.
Well, there is a problem with compatibility if removing SLF4JLogging
, because Slf4jLogger
is public api and not final. Someone may have extended it and expect that log
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's also another point.
References #31395
This would significantly enlarge the change to get slf4j warning silent