Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and adding tests for better test coverage #1122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fstroth
Copy link
Contributor

@fstroth fstroth commented Jul 17, 2022

This PR is still work in progress! Pls don't merge yet!

The goal is to add tests for parts that are not covered atm to prepare for the big changes that will come with the lib restructure.

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #1122 (8cedaea) into master (ba6a714) will increase coverage by 2.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   85.48%   87.64%   +2.15%     
==========================================
  Files         305      305              
  Lines        6675     6675              
==========================================
+ Hits         5706     5850     +144     
+ Misses        969      825     -144     
Flag Coverage Δ
unittests 87.64% <ø> (+2.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/models/checkpoint.py 83.56% <ø> (+72.60%) ⬆️
icevision/core/class_map.py 76.00% <0.00%> (+2.00%) ⬆️
icevision/core/record_components.py 84.79% <0.00%> (+3.21%) ⬆️
icevision/widgets/__init__.py 100.00% <0.00%> (+100.00%) ⬆️
icevision/widgets/model_choice_ui.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6a714...8cedaea. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant