Remove manual torch.no_grad and train eval mode in LightningModule
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketmaurya
commented
May 16, 2022
| self.accumulate_metrics(preds=preds) | ||
| self.train() | ||
| train_preds = self(xb, yb) | ||
| loss = loss_fn(train_preds, yb) |
There was a problem hiding this comment.
I wasn't able to understand why do we calculate training prediction here?
There was a problem hiding this comment.
Maybe the name is misleading , these are in fact validation preds. These are used to calculate validation loss and metrics
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
=======================================
Coverage 85.43% 85.44%
=======================================
Files 301 301
Lines 6600 6594 -6
=======================================
- Hits 5639 5634 -5
+ Misses 961 960 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Any idea why black formatting check might failing here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PL LightningModule automatically sets train and eval mode and
torch.no_gradduring the training and validation steps.