Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source MailerLite: Correct schemas, Migrate with poetry, Make Connector Compatible with Builder #38342

Merged
merged 19 commits into from
May 28, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 20, 2024
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:18pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 20, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 20, 2024 06:15
@btkcodedev btkcodedev changed the title ✨Source MailerLite: Make Connector Compatible with Builder ✨Source MailerLite: Correct schemas, Migrate with poetry, Make Connector Compatible with Builder May 20, 2024
@btkcodedev btkcodedev requested a review from girarda May 20, 2024 09:00
message:
"The verison migrates the MailerLite connector to the be compatable for connector builder.
Important:
The forms_popup stream schema from API has a breaking change to schema['properties']['settings']['properties']['schedule'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btkcodedev is the breaking change related to the migration or has there been an API change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API field changes only

Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 21, 2024 15:51
@btkcodedev
Copy link
Collaborator Author

@girarda Comments resolved and CI green
image

@btkcodedev btkcodedev requested a review from girarda May 28, 2024 07:52
docs/integrations/sources/mailerlite.md Outdated Show resolved Hide resolved
@girarda girarda merged commit baaad77 into master May 28, 2024
30 of 31 checks passed
@girarda girarda deleted the btkcodedev/mailerLite branch May 28, 2024 22:04
xiaohansong pushed a commit that referenced this pull request May 29, 2024
…tor Compatible with Builder (#38342)

Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailerlite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants