-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[source-linkedin-ads]: migrate to low-code #38314
base: master
Are you sure you want to change the base?
refactor[source-linkedin-ads]: migrate to low-code #38314
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
/format-fix
|
…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
airbyte-integrations/connectors/source-linkedin-ads/pyproject.toml
Outdated
Show resolved
Hide resolved
…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
Unit test for custom components in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really struggling with live testing and therefore have no easy way to test that. I've communicated the issues with the extensibility team. In the meanwhile, I'll test manually but the validation will be longer though...
airbyte-integrations/connectors/source-linkedin-ads/integration_tests/abnormal_state.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using connection 7d376aaf-f420-4b71-8131-f2ad21287398
, I get different results:
Read 12 records from account_users stream
with low-code whileRead 6 records from account_users stream
with most recent versionRead 41 records from accounts stream
with low-code whileRead 1 records from accounts stream
with most recent versionRead 9 records from campaign_groups stream
with low-code whileRead 14 records from campaign_groups stream
with most recent version
etc...
Are those changes expected? Should we investigate them?
What
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/7804
How
We have migrated streams to a low-code platform. However, the analytics streams remain in Python, as the low-code implementation requires custom logic for slicing, parsing records, and mapping records that were sliced into fields by chunks.
Review guide
manifest.yaml
source.py
User Impact
Format of state has changed for incremental streams, primary key has changed for
account_users
streamCan this PR be safely reverted and rolled back?