fix: handle differing source and result sizes in updateCanvas #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateCanvas
has a bug which only really comes to light if the size of the canvas and the size of the original image differ drastically and the image offset is positive. Thedx
anddy
are not adjusted for the size difference.Here is a visual representation:
Since the output (100px) is half the size of the input (200px) the
dx
anddy
have to be halfed.The same issue seems to exist in the master branch. I'll gladly also create a PR for the master branch, once this is merged :)