Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in the Pinterest Social Icon #1420

Closed
wants to merge 1 commit into from
Closed

Adding in the Pinterest Social Icon #1420

wants to merge 1 commit into from

Conversation

zacharyc
Copy link

@zacharyc zacharyc commented Feb 8, 2024

What does this PR change? What problem does it solve?
This problem adds in the Pinterest social icon to the social icons feed.

image
image

Was the change discussed in an issue or in the Discussions before?

#1204

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zacharyc
Copy link
Author

@adityatelange, what is the process for getting this approved and merged?

adityatelange
adityatelange requested changes Mar 2, 2024
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityatelange, what is the process for getting this approved and merged?

The viewbox is not set properly here

@adityatelange adityatelange added the icons Related to Icons label Apr 20, 2024
@adityatelange
Copy link
Owner

fixed by #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange requested changes

Assignees
No one assigned
Labels
icons Related to Icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zacharyc @adityatelange