Fixed hiddenInHomeList logic to use a boolean. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would check for the string "true" instead of the boolean true. This made it so that 'hiddenInHomeList: false' would hide a page, instead of showing it. This fixes this by using a boolean.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@aisotton with which config file type it was an issue with? yml, json, toml? |
|
It was a toml file. I didn't try the others.
…On Sat, Jul 15, 2023 at 12:21 AM Aditya Telange ***@***.***> wrote:
@aisotton <https://github.com/aisotton> with which config file type it
was an issue with? yml, json, toml?
—
Reply to this email directly, view it on GitHub
<#1264 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIV6LB3NCCAQNU7F5EFCVTXQIZIDANCNFSM6AAAAAA2K2PBLI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Are you ok with this change? |
adityatelange
force-pushed
the
master
branch
from
bcd75b6
to
55b2eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would check for the string "true" instead of the boolean true. This made it so that 'hiddenInHomeList: false' would hide a page, instead of showing it.
This fixes this by using a boolean.
What does this PR change? What problem does it solve?
The previous code would check for the string "true" instead of the boolean true. This made it so that 'hiddenInHomeList: false' would hide a page, instead of showing it.
Was the change discussed in an issue or in the Discussions before?
No
PR Checklist