Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit_post fileUrlPath with contentDir configured #1243

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

genffy
Copy link

@genffy genffy commented Jun 20, 2023

What does this PR change? What problem does it solve?

  • change
    edit_post.html $fileUrlPath variable, use
  • solve for
    fix the wrong path with contentDir param is configured
  • ⚠️ side effect
    if editPost.URL configured as the end of 'content'(this is contentDir default value ) will get the wrong path,
    but I think the default value should not be write in config file, should use a variable instead

the doc of editPost should be updated, Notice that just config it to the repo with the branch without /content

Was the change discussed in an issue or in the Discussions before?
nop

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@genffy genffy changed the title fix: edit_post fileUrlPath with contentDir configed fix: edit_post fileUrlPath with contentDir configured Jun 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant