Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui/logs: fix parsing long _msg values #6310

Merged
merged 2 commits into from
May 22, 2024

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented May 20, 2024

This PR fixes an issue where parsing long _msg values caused errors, resulting in some log records not being displayed.

The error occurred due to partial processing of strings. In some cases, a long record could be split into multiple chunks, causing only part of the record to be processed instead of the entire entry.

#6281

@valyala valyala merged commit 75bd183 into master May 22, 2024
3 checks passed
@valyala valyala deleted the vmui/logs/issue-6281/fix-response-parsing branch May 22, 2024 19:44
@valyala
Copy link
Collaborator

valyala commented May 22, 2024

@Loori-R , thanks for the fix!

valyala added a commit that referenced this pull request May 22, 2024
This PR fixes an issue where parsing long `_msg` values caused errors,
resulting in some log records not being displayed.

The error occurred due to partial processing of strings. In some cases,
a long record could be split into multiple chunks, causing only part of
the record to be processed instead of the entire entry.

#6281

Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants