Vmselect slow query https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5134 #6167
+87
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: root <root@C-5CG324677Z>
Haleygo
reviewed
Jun 11, 2024
| @@ -902,6 +956,32 @@ var ( | |||
| httpRequestsDuration = tenantmetrics.NewCounterMap(`vm_tenant_select_requests_duration_ms_total`) | |||
| ) | |||
|
|
|||
| var ( | |||
| slowQueries = metrics.NewCounter(`vm_slow_queries_total{path="*"}`) | |||
There was a problem hiding this comment.
This metric can be removed, since it's the same as sum(vm_slow_queries_total{path!=""}).
| @@ -182,6 +180,61 @@ var ( | |||
| }) | |||
| ) | |||
|
|
|||
| func updateSlowQueryPathCounter(p *httpserver.Path, path string) { | |||
There was a problem hiding this comment.
I don't think we need a duplicated function to identify the query path, we can increase counters in the original handler.
The code can be like this
var slowQueries *metrics.Counter
if *logSlowQueryDuration > 0 {
actualStartTime := time.Now()
defer func() {
d := time.Since(actualStartTime)
if d >= *logSlowQueryDuration {
...
slowQueries.Inc()
}
}()
}
...
if path == "/admin/tenants" {
tenantsRequests.Inc()
slowQueries = pathSlowTenantsRequests
...
// selectHandler()
switch p.Suffix {
case "prometheus/api/v1/query":
queryRequests.Inc()
slowQueries = pathSlowQuery
httpserver.EnableCORS(w, r)
if err := prometheus.QueryHandler(qt, startTime, at, w, r); err != nil {
queryErrors.Inc()
sendPrometheusError(w, r, err)
return true
}
return true
case "prometheus/api/v1/query_range":
queryRangeRequests.Inc()
slowQueries = pathSlowQueryRange
| @@ -234,6 +287,11 @@ func requestHandler(w http.ResponseWriter, r *http.Request) bool { | |||
| return true | |||
| } | |||
| } | |||
| p, err := httpserver.ParsePath(path) | |||
There was a problem hiding this comment.
This check can't be moved before handlers /internal/resetRollupResultCache and /admin/tenants, it requires path to have /{prefix}/{tenantID}/{suffix} form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s/issues/5134
Describe Your Changes
Please provide a brief description of the changes you made. Be as specific as possible to help others understand the purpose and impact of your modifications.
Checklist
The following checks are mandatory: