Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gs.mclo:api from 3.0.1 to 4.0.1 #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 16, 2023

Bumps gs.mclo:api from 3.0.1 to 4.0.1.

Release notes

Sourced from gs.mclo:api's releases.

v4.0.1

  • fix accept header name

v4.0.0

  • Update dependencies
  • Utilize CompletableFuture to wrap around API calls
  • API calls are now async
  • Moved visibility of all fields to private, some are also final
  • Utilizes Java 11s HttpClient
Commits
  • d6aa68c Update changelog
  • 773040e Set gradle to target Java 11
  • 2fabe5a Fix accept header name, remove unused exceptions
  • ce4d4cc Update examples and dependency versions in README
  • dc87ed9 run release workflow with java 11
  • 56e6744 Merge pull request #7 from TheRealRyGuy/master
  • 0bb6057 update dependencies, changelog
  • cf5509e Migrate to CompletableFuture / HttpClient usage, misc changes
  • 898e889 Cache gradle dependencies, skip daemon
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [gs.mclo:api](https://github.com/aternosorg/mclogs-java) from 3.0.1 to 4.0.1.
- [Release notes](https://github.com/aternosorg/mclogs-java/releases)
- [Commits](aternosorg/mclogs-java@3.0.1...4.0.1)

---
updated-dependencies:
- dependency-name: gs.mclo:api
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 16, 2023
Copy link
Member

@Kichura Kichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly alright although unsure if this is compatible with JDK 8 variant of viaproxy, if it is - safe to merge.

@RaphiMC
Copy link
Member

RaphiMC commented Feb 8, 2024

It wont be compatible thats why I am not merging it. Going to leave it open tho in case I am dropping Java 8 at some time in the future

@Kichura
Copy link
Member

Kichura commented Feb 8, 2024

It wont be compatible thats why I am not merging it. Going to leave it open tho in case I am dropping Java 8 at some time in the future

Will viaproxy change the lowest compatible java version to 11 or go straight to 17?

@RaphiMC
Copy link
Member

RaphiMC commented Feb 8, 2024

Don't know yet but probably 11 if no dependencies require 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants