Add Dockerfile and automated image building #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexProgrammerDE
suggested changes
May 14, 2024
| FROM --platform=$TARGETPLATFORM eclipse-temurin:21-jre-alpine | ||
| WORKDIR /app | ||
| COPY --from=builder /build/build/libs/ViaProxy-*.jar ViaProxy.jar | ||
| ENTRYPOINT ["java", "-jar", "ViaProxy.jar"] |
There was a problem hiding this comment.
These java args are pretty barebones. You'd also want controllable RAM and gc flags.
There was a problem hiding this comment.
The default JVM arguments here would be G1GC with 2 GB of RAM allocated to it as far as i'm aware, however if needed then optimizations should be thought upon.
There was a problem hiding this comment.
I think i should be able to make the args passed to java controllable with for example a JAVA_OPTS env variable
Kichura
suggested changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a github action and a Dockerfile to build a container image for the app. It is then also hosted on the GitHub Container Registry