Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BetterRoleContext): Add option to view role icons #2482

Merged
merged 14 commits into from
May 21, 2024
Merged

feat(BetterRoleContext): Add option to view role icons #2482

merged 14 commits into from
May 21, 2024

Conversation

schoeneBiene
Copy link
Contributor

@schoeneBiene schoeneBiene commented May 19, 2024 •
edited

Vencord/plugin-requests#346

Adds a "View Role Icon" option on the role context menu.

@schoeneBiene schoeneBiene marked this pull request as draft May 19, 2024 12:38
@schoeneBiene
Copy link
Contributor Author

Marking as draft because I realized putting this function into the already existing plugin ViewIcons & using Discord's preview would probably be better.

@schoeneBiene schoeneBiene changed the title new plugin: SaveRoleIcon feat(ViewIcons): Add option to view role icons May 19, 2024
@schoeneBiene schoeneBiene marked this pull request as ready for review May 19, 2024 12:54
@Vendicated
Copy link
Owner

i think this would make more sense to be added as part of https://vencord.dev/plugins/BetterRoleContext

@schoeneBiene
Copy link
Contributor Author

i think this would make more sense to be added as part of https://vencord.dev/plugins/BetterRoleContext

I was thinking about that, will do.

@schoeneBiene schoeneBiene changed the title feat(ViewIcons): Add option to view role icons feat(BetterRoleContext): Add option to view role icons May 19, 2024
Vendicated
Vendicated reviewed May 20, 2024
View reviewed changes
Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution! please make sure you stay consistent with the rest of the code

src/plugins/betterRoleContext/index.tsx Show resolved Hide resolved
src/plugins/betterRoleContext/index.tsx Outdated Show resolved Hide resolved
src/plugins/betterRoleContext/index.tsx Outdated Show resolved Hide resolved
src/plugins/betterRoleContext/index.tsx Outdated Show resolved Hide resolved
schoeneBiene and others added 2 commits May 20, 2024 15:01
@schoeneBiene
Copy link
Contributor Author

Made the requested changes

@Vendicated Vendicated changed the base branch from main to dev May 21, 2024 00:16
@Vendicated Vendicated enabled auto-merge (squash) May 21, 2024 00:23
@Vendicated
Copy link
Owner

thank you!!

@Vendicated Vendicated merged commit 9c092b9 into Vendicated:dev May 21, 2024
1 check passed
@schoeneBiene schoeneBiene deleted the copy-role-icon branch May 23, 2024 06:58
ImLvna pushed a commit to ImLvna/Vencord that referenced this pull request May 27, 2024
@schoeneBiene @Vendicated @ImLvna
feat(BetterRoleContext): Add option to view role icons (Vendicated#2482)
0473aee 
Co-authored-by: vee <vendicated@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vendicated Vendicated Vendicated left review comments

@Scyye Scyye Scyye left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schoeneBiene @Vendicated @Scyye