Add SMART_HIGH_ODDS strategy #172

1v · 2021-05-06T15:00:34Z

Description

Adds new strategy.

Type of change

Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented on my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (README.md)
My changes generate no new warnings
Any dependent changes have been updated in requirements.txt

Tkd-Alex · 2021-05-23T13:26:25Z

@1v Please review your code

1v · 2021-05-23T17:42:40Z

It probably requires refactoring. I have zero experience with python, learning on this repo.

1v · 2021-05-24T00:31:59Z

I also made stats console output.

Worth adding pull request?

Tkd-Alex · 2021-08-16T20:07:11Z

Hi! @1v
Have you timed to finish this PR? Don't worry about the check fails, I can review later if you want :)
If you want to learn, please read https://github.com/Tkd-Alex/Twitch-Channel-Points-Miner-v2/blob/master/CONTRIBUTING.md

1v · 2021-08-17T16:43:28Z

Hi @Tkd-Alex. What I need to do? I think what currently in PR is ok.
But honestly I think Bet class should be refactored. I'm adding target_odd strategy specific setting to common settings, that's feels not right.
I think strategies should be moved from Bet class. skip and calculate methods should be moved to main strategy class. Other strategies should inherit main strategy class. skip and calculate methods in strategy specific class should be possible to be partially adjusted or completely replaced. There should be possibility to add strategy specific settings.

Tkd-Alex · 2021-08-17T20:39:00Z

Yup, convert Strategy Enum to a custom class could be an idea of refactory.
The new SMART_HIGH_ODDS strategy It's the only one that need additional parameters?

1v · 2021-08-18T10:35:05Z

SMART strategy also has percentage_gap.

…h_odds

1v · 2021-10-06T21:41:57Z

@Tkd-Alex I'm currently refactoring and it looks good to me. Also adding tests.

* Move code from skip() and calculate() methods to Strategy class * Add pytest * Add tests

* Move Strategy class from Bet.py into separate Strategy.py

…s/docker/login-action-2.1.0 Bump docker/login-action from 2.0.0 to 2.1.0

…s/docker/setup-qemu-action-2.1.0 Bump docker/setup-qemu-action from 2.0.0 to 2.1.0

…s/docker/build-push-action-3.2.0 Bump docker/build-push-action from 3.1.1 to 3.2.0

FirstThread · 2023-01-29T22:54:30Z

Hi, is it possible to implement the TwitchLogin like in the Main repo? I cant log in with the Login in 1v:smart_high_odds. I would like to Test the SMART_HIGH_ODDS feature and give feedback :)

1v · 2023-01-30T07:16:58Z

@FirstThread hi, can you login with main repo? I guess predictions is not working in main repo. I tried fork but I failed to install chrome executables. So I don't run this script anymore, but it should work if you manage to make predictions work, because tests are passing.

FirstThread · 2023-01-30T09:54:25Z

Hi, yes i can login with the main repo and predictions are working fine:

30/01/23 10:21:44 - INFO - [on_message]: ⏰ Place the bet after: 89.99s for: EventPrediction(event_id=77f4f9c7-0b0f-4e11-acd0-cf4ab429af67, streamer=Streamer(username=rax1337, channel_id=28213443, channel_points=13.66k), title=Das nächste Match wird?)
30/01/23 10:23:14 - INFO - [make_predictions]: 🍀 Going to complete bet for EventPrediction(event_id=77f4f9c7-0b0f-4e11-acd0-cf4ab429af67, streamer=Streamer(username=rax1337, channel_id=28213443, channel_points=13.66k), title=Das nächste Match wird?)
30/01/23 10:23:14 - INFO - [make_predictions]: 🍀 Place 1.37k channel points on: Gewonnen (BLUE), Points: 184k, Users: 26 (68.42%), Odds: 1.42 (70.42%)

The only problem is that I can't log in to your version with SMART_HIGH_ODDS. Is it possible to do the registration like in the main repo with https://www.twitch.tv/activate?

1v · 2023-01-30T10:02:09Z

But is it really placing the bet?

FirstThread · 2023-01-30T10:02:44Z

It is

1v · 2023-01-30T10:47:13Z

yes i can login with the main repo and predictions are working fine

How do you logged in? I tried clean install and I get:

30/01/23 13:39:34 - ERROR - [login_flow]: Unknown error: {'error': 'Please update your app to continue', 'error_code': 5023, 'error_description': 'client is not supported for this feature'}

FirstThread · 2023-01-30T13:49:15Z

I'll Reinstall this evening and i'll send you all the steps i did.

FirstThread · 2023-01-30T22:53:25Z

The things i did:

git clone https://github.com/Tkd-Alex/Twitch-Channel-Points-Miner-v2.git
cd Twitch-Channel-Points-Miner-v2/
python -m venv venv
source venv/bin/activate
pip install -r requirements.txt
vim example.py added my TwitchUsername and Password and added one Streamer and Emoji to False (The Startup did only work for me if i set Emojis to False.
python example.py

Login into my Twitch Account on the given domain

1v · 2023-01-31T07:48:26Z

It says "by rdavydov" I don't have these log messages. And I'm cloning exactly like you.
Also I'm using wsl ubuntu not docker.

FirstThread · 2023-01-31T08:46:13Z

This is running on a Synology machine. I think it says "by rdavydov" because the origin of the channel point miner is from rdavydov. Your error is the same as #685 which was fixed in release 1.6.0 and 1.7.0.

PS: I think i had the same issue too, if i had Emojis on True, i know they have no direct correlation, but it worked for me.

1v · 2023-01-31T12:02:57Z

No, disabling emoji not helped.
#685 it doesn't say bug is fixed there. I guess it fixed in rdavydov fork. But I couldn't run this fork.

FirstThread · 2023-01-31T17:28:00Z

I am very sorry. I made a mistake, because the two repos refer to each other, I cloned the wrong repo. So I use the rdavydov repo all the time. sorry for the confusion. Is it possible to do the twitch login method the same as the rdavydov repo? What error do you get when you try to run the rdavydov repo?

rdavydov · 2023-01-31T17:32:43Z

git clone https://github.com/rdavydov/Twitch-Channel-Points-Miner-v2.git

You don't need Chrome in the latest version 1.7.0.

FirstThread · 2023-01-31T17:34:15Z

Thats correct. Im using the Bot on a Synology Nas, and this is a headless machine.

rdavydov · 2023-01-31T21:18:09Z

@1v @FirstThread May I integrate this new strategy into my fork? So more people will be able to test it properly.

I guess I can just incorporate this commit 84b3dbe

FirstThread · 2023-01-31T21:19:19Z

I would love that :)

1v · 2023-02-01T07:35:33Z

@rdavydov No, this commit is not enough. Here diff https://github.com/rdavydov/Twitch-Channel-Points-Miner-v2/compare/master...1v:Twitch-Channel-Points-Miner-v2:smart_high_odds?expand=1 not everything is needed here.
Here files need to be copied (changes)
README.md
TwitchChannelPointsMiner/classes/entities/Bet.py (replace whole file)
TwitchChannelPointsMiner/classes/entities/Strategy.py
TwitchChannelPointsMiner/classes/entities/strategies/ (whole folder)
example.py
pytest.ini
tests/test_bet.py

Then run pytest. It should work right away, because I fixed it in your fork.
Other changes in pull request can be ignored.
Btw it will be not back compatible because of new option strategy_settings and because option percentage_gap is moved to strategy_settings.

1v · 2023-02-09T20:41:21Z

@rdavydov I'm about to submit pull request with this changes. But it needs testing before merging. Do you know how to test it faster?

arie-2 · 2023-02-25T23:11:44Z

This doesn't seem to work if you try so setup custom settings for specific streamers, default settings work fine

twitch_miner.mine(
  [
    Streamer("xQc",
             settings=StreamerSettings(make_predictions=True,
                                       follow_raid=True,
                                       claim_drops=True,
                                       watch_streak=True,
                                       bet=BetSettings(
                                         delay_mode=DelayMode.FROM_START,
                                         delay=45,
                                         filter_condition=FilterCondition(
                                           by=OutcomeKeys.TOTAL_USERS,
                                           where=Condition.LTE,
                                           value=5000)))),
...

Error message:

25/02/23 23:06:09 - INFO - [__init__]: Twitch Channel Points Miner v2-1.7.4 (fork by rdavydov)
25/02/23 23:06:09 - INFO - [__init__]: https://github.com/rdavydov/Twitch-Channel-Points-Miner-v2
Traceback (most recent call last):
  File "run.py", line 117, in <module>
    bet=BetSettings(
  File "/home/runner/Twitch-Channel-Points-Miner-v2-smart-high-odds/TwitchChannelPointsMiner/classes/entities/Bet.py", line 86, in __init__
    self.strategy_settings = StrategySettings(
TypeError: type object argument after ** must be a mapping, not NoneType

1v · 2023-02-26T10:34:38Z

This pull request is outdated. There is new one rdavydov#141.

Add SMART_HIGH_ODDS strategy

125a08a

Add only_doubt option and improve SMART_HIGH_ODDS strategy

8c47c43

Tkd-Alex added the enhancement New feature or request label Aug 16, 2021

1v added 3 commits September 30, 2021 18:10

Add always_bet option

9479ab5

Merge remote-tracking branch 'upstream/master' into smart_high_odds

ef1c109

Merge remote-tracking branch 'upstream/wout-helix-api' into smart_hig…

db1f65a

…h_odds

1v force-pushed the smart_high_odds branch from 1e9fea2 to db1f65a Compare October 1, 2021 09:59

Merge remote-tracking branch 'upstream/master' into smart_high_odds

e0632ae

1v added 11 commits October 8, 2021 20:49

Refactor Bet class

c77e78a

* Move code from skip() and calculate() methods to Strategy class * Add pytest * Add tests

Add StrategySettings

9e19617

* Move Strategy class from Bet.py into separate Strategy.py

Add tests

54de3b6

Add pytest to github CI

86245b3

Add requirements to CI

c0c8dc6

Fix README and example.py

07e125e

Merge remote-tracking branch 'upstream/master' into smart_high_odds

9986a5a

Add stats

f0ab436

Merge remote-tracking branch 'origin/stats' into smart_high_odds

94d2950

Move each strategy to separate files

d1b3217

Merge remote-tracking branch 'origin' into smart_high_odds

96edbb3

1v force-pushed the smart_high_odds branch 2 times, most recently from 96edbb3 to 07e125e Compare October 22, 2021 05:05

Move each strategy to separate files

f545901

rdavydov and others added 10 commits December 8, 2022 20:34

Merge pull request Tkd-Alex#81 from rdavydov/dependabot/github_action…

f956b5c

…s/docker/login-action-2.1.0 Bump docker/login-action from 2.0.0 to 2.1.0

Merge pull request Tkd-Alex#80 from rdavydov/dependabot/github_action…

50fe336

…s/docker/setup-qemu-action-2.1.0 Bump docker/setup-qemu-action from 2.0.0 to 2.1.0

Merge pull request Tkd-Alex#79 from rdavydov/dependabot/github_action…

36cd602

…s/docker/build-push-action-3.2.0 Bump docker/build-push-action from 3.1.1 to 3.2.0

new android app ver, show err 5023

ea2a47c

1.5.4 temporary login fix

163d7de

debug config

e7a1070

fix Tkd-Alex#85

6369fbe

:Merge remote-tracking branch 'rdavydov/master' into smart_high_odds

28ab872

Fix tests

84b3dbe

Remove deploy-docker.yml

800752a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SMART_HIGH_ODDS strategy #172

Add SMART_HIGH_ODDS strategy #172

1v commented May 6, 2021 •

edited

Tkd-Alex commented May 23, 2021

1v commented May 23, 2021

1v commented May 24, 2021 •

edited

Tkd-Alex commented Aug 16, 2021

1v commented Aug 17, 2021

Tkd-Alex commented Aug 17, 2021

1v commented Aug 18, 2021

1v commented Oct 6, 2021 •

edited

FirstThread commented Jan 29, 2023

1v commented Jan 30, 2023

FirstThread commented Jan 30, 2023

1v commented Jan 30, 2023

FirstThread commented Jan 30, 2023

1v commented Jan 30, 2023

FirstThread commented Jan 30, 2023

FirstThread commented Jan 30, 2023

1v commented Jan 31, 2023 •

edited

FirstThread commented Jan 31, 2023 •

edited

1v commented Jan 31, 2023

FirstThread commented Jan 31, 2023

rdavydov commented Jan 31, 2023

FirstThread commented Jan 31, 2023

rdavydov commented Jan 31, 2023

FirstThread commented Jan 31, 2023

1v commented Feb 1, 2023 •

edited

1v commented Feb 9, 2023

arie-2 commented Feb 25, 2023

1v commented Feb 26, 2023

Add SMART_HIGH_ODDS strategy #172

Are you sure you want to change the base?

Add SMART_HIGH_ODDS strategy #172

Conversation

1v commented May 6, 2021 • edited

Description

Type of change

How Has This Been Tested?

Checklist:

Tkd-Alex commented May 23, 2021

1v commented May 23, 2021

1v commented May 24, 2021 • edited

Tkd-Alex commented Aug 16, 2021

1v commented Aug 17, 2021

Tkd-Alex commented Aug 17, 2021

1v commented Aug 18, 2021

1v commented Oct 6, 2021 • edited

FirstThread commented Jan 29, 2023

1v commented Jan 30, 2023

FirstThread commented Jan 30, 2023

1v commented Jan 30, 2023

FirstThread commented Jan 30, 2023

1v commented Jan 30, 2023

FirstThread commented Jan 30, 2023

FirstThread commented Jan 30, 2023

1v commented Jan 31, 2023 • edited

FirstThread commented Jan 31, 2023 • edited

1v commented Jan 31, 2023

FirstThread commented Jan 31, 2023

rdavydov commented Jan 31, 2023

FirstThread commented Jan 31, 2023

rdavydov commented Jan 31, 2023

FirstThread commented Jan 31, 2023

1v commented Feb 1, 2023 • edited

1v commented Feb 9, 2023

arie-2 commented Feb 25, 2023

1v commented Feb 26, 2023

1v commented May 6, 2021 •

edited

1v commented May 24, 2021 •

edited

1v commented Oct 6, 2021 •

edited

1v commented Jan 31, 2023 •

edited

FirstThread commented Jan 31, 2023 •

edited

1v commented Feb 1, 2023 •

edited