Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for GC's Player Controllers #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IgnisAlienus
Copy link
Contributor

Support for GC's Player Controllers.

I added them in the log-parser as new files instead of messing with and possibly breaking old files.

This may need to be done for any other mods that mess with the BP name for the Player Controller.

Let me know if there's a better way to implement this. But this is working for me on our Server.

@steelskillet
Copy link
Contributor

steelskillet commented Feb 1, 2024

might be able to just loosen the regex for the player controllers. I don't think they need the current "BP_PlayerContoller_C" and we might just be able to use ".+" instead.

@IgnisAlienus
Copy link
Contributor Author

might be able to just loosen the regex for the player controllers. I don't think they need the current "BP_PlayerContoller_C" and we might just be able to use ".+" instead.

Yeah, that would work just as well if it won't break anything else.

@werewolfboy13
Copy link
Collaborator

Is there plugins out now that would benefit from this?

@IgnisAlienus
Copy link
Contributor Author

People that have custom time tracking plugins. I think the other guy my be onto something where the regex on the one is made less specific for the controller. As long as that doesn't break anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants