Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile and Action for creating Docker image in GitHub's registry #317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Sentennial
Copy link
Contributor

No description provided.

@sullivandavid42
Copy link

Any update about this merge request ? Would be glad to see this container in action ! :)

@werewolfboy13
Copy link
Collaborator

@sullivandavid42 legit didn’t know this was a PR. The docker file at a minimum is broken as such I can’t push this. Will make a change request when I can.

@wojski
Copy link

wojski commented Apr 13, 2024

Yes, you don't need to install nodejs / pm2 in your system. Its just an option if somebody want to run it via docker (For example we are running it in docker from day 0)

@wojski
Copy link

wojski commented Apr 13, 2024

Working dockerfile if anyone need ;)

FROM node:18.17-alpine
USER node
RUN mkdir -p /home/node/app
WORKDIR /home/node/app
COPY --chown=node . .
RUN yarn install && yarn cache clean
CMD ["node", "index.js"]

@D4n2021
Copy link

D4n2021 commented Apr 13, 2024

Working dockerfile if anyone need ;)

FROM node:18.17-alpine
USER node
RUN mkdir -p /home/node/app
WORKDIR /home/node/app
COPY --chown=node . .
RUN yarn install && yarn cache clean
CMD ["node", "index.js"]

So is this for Windows aswell then or just Linux? Because here it only lists Linux, although top right says "multiplatform".

grafik

@fantinodavide
Copy link
Contributor

Working dockerfile if anyone need ;)

FROM node:18.17-alpine
USER node
RUN mkdir -p /home/node/app
WORKDIR /home/node/app
COPY --chown=node . .
RUN yarn install && yarn cache clean
CMD ["node", "index.js"]

So is this for Windows aswell then or just Linux?

Docker works on Linux and Windows (on WSL) and the docker image is used to standardize the environment that will run an application, regardless of the OS.

@D4n2021
Copy link

D4n2021 commented Apr 13, 2024

Just edited my previous post.

@fantinodavide
Copy link
Contributor

Just edited my previous post.

This is becoming off-topic but I can suggest to read this page in which everything is very well explained: https://docs.docker.com/get-started/overview/
If you need more clarifications I also suggest to move this conversation on discord, feel free to DM me, my username is jetdave

@Team-Silver-Sphere Team-Silver-Sphere deleted a comment from D4n2021 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants