-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(svelte-query): specify StoreOrVal options in function signature #7453
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5702587. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
===========================================
+ Coverage 41.42% 65.75% +24.32%
===========================================
Files 184 17 -167
Lines 7331 146 -7185
Branches 1531 29 -1502
===========================================
- Hits 3037 96 -2941
+ Misses 3889 44 -3845
+ Partials 405 6 -399
|
Summary
Expose the
CreateMutationOptions
as a regular object, and wrap it withStoreOrVal
in thecreateMutation
function signature.Reasoning
Aside from being inconvenient if I wanted to refer to the unwrapped mutation options object, it seems to be inconsistent with the other type definitions for query options?
createQuery
,createInfiniteQuery
both haveStoreOrVal
wrapped around their options in their function signature, and the exposed type for options is just an object.