-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix pk table compact crash when light compaction is disable #45855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohaha
force-pushed
the
fix-light-compact-crash2
branch
2 times, most recently
from
May 19, 2024 14:41
b7babdd
to
1c14a6b
Compare
Signed-off-by: luohaha <18810541851@163.com>
luohaha
force-pushed
the
fix-light-compact-crash2
branch
from
May 19, 2024 14:49
1c14a6b
to
ac68a69
Compare
sevev
previously approved these changes
May 20, 2024
wyb
previously approved these changes
May 20, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 19 / 26 (73.08%) file detail
|
sevev
approved these changes
May 20, 2024
wyb
approved these changes
May 20, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
Merged
42 tasks
Merged
42 tasks
Merged
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
There are two issues:
enable_light_pk_compaction_publish
is false,std::vector<uint64_t> rssid_rowids
inMergeEntry
will be empty, and this code will cause crash:And real crash stack will be:
union_iterator
doesn't supportStatus UnionIterator::do_get_next(Chunk* chunk, std::vector<uint64_t>* rssid_rowids)
.Which will lead to compaction failure like:
What I'm doing:
Fix this crash.
Fix https://github.com/StarRocks/StarRocksTest/issues/7449
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: