-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] multiple sys_log_to_console=true entry in fe.conf every time… #45851
Open
rohitrs1983
wants to merge
4
commits into
StarRocks:main
Choose a base branch
from
rohitrs1983:fe_sys_log_to_console
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
kevincai
reviewed
May 20, 2024
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
kevincai
reviewed
May 21, 2024
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
kevincai
reviewed
May 28, 2024
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
Quality Gate passedIssues Measures |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
multiple sys_log_to_console=true entry in fe.conf every time fe is started with --logconsole option
What I'm doing:
fe.conf should have only single entry sys_log_to_console=true
Fixes #45850
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: