Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] multiple sys_log_to_console=true entry in fe.conf every time… #45851

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rohitrs1983
Copy link
Contributor

@rohitrs1983 rohitrs1983 commented May 18, 2024

Why I'm doing:

multiple sys_log_to_console=true entry in fe.conf every time fe is started with --logconsole option

What I'm doing:

fe.conf should have only single entry sys_log_to_console=true

Fixes #45850

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

… fe is started with --logconsole option

Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
bin/start_fe.sh Outdated Show resolved Hide resolved
… fe is started with --logconsole option

Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
@rohitrs1983 rohitrs1983 requested a review from kevincai May 20, 2024 17:38
… fe is started with --logconsole option

Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
@rohitrs1983 rohitrs1983 requested a review from kevincai May 25, 2024 05:59
Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Log4jConfig.java 1 1 100.00% []

… fe is started with --logconsole option

Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
@rohitrs1983 rohitrs1983 requested a review from kevincai June 1, 2024 10:33
Copy link

sonarcloud bot commented Jun 1, 2024

Copy link

github-actions bot commented Jun 1, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BugFix] multiple sys_log_to_console=true entry in fe.conf every time fe is started with --logconsole option
2 participants