Fix edit button of printer combo box not updates its color after theme switch #5412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other combos uses same method but this one is missing for printer combo box
Note bug only appear if you start with light theme then switch to dark theme. Button rendered with normal color if orca starts with dark theme. And bug exist for opposite
Screenshots/Recordings/Graphs
all edit buttons uses same color with with fix. Button uses #949494 color
printer combo edit button uses color from light theme without fix. Button uses #7C8282 color
it exist for other 2 types of combo boxes but not on printer combo box
OrcaSlicer/src/slic3r/GUI/PresetComboBoxes.cpp
Lines 1133 to 1145 in b04a57d
OrcaSlicer/src/slic3r/GUI/PresetComboBoxes.cpp
Lines 1548 to 1557 in b04a57d
Tests
windows 10