Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

05-14 [Flashforge] fix 5M gcode and consolidate the filenaming #5360

Closed
wants to merge 0 commits into from

Conversation

Bai825
Copy link

@Bai825 Bai825 commented May 14, 2024

Description

  1. Fix the 5M series gcode
  2. Fix the compatible printers for G3U filaments
  3. Improve the filenaming

Screenshots/Recordings/Graphs

1
2
3

Tests

Profiles running normally on local portable version.

@Bai825
Copy link
Author

Bai825 commented May 14, 2024

Hi, @SoftFever ,for your review!

@RikshaDriver
Copy link
Contributor

@Bai825 remove the additional "flashfoge" STL files as they are not required.

@SoftFever
Copy link
Owner

There are errors, please check

@RikshaDriver
Copy link
Contributor

@FlashforgeOfficial @Bai825 @FlashForge what about removal of legacy filament files?

Regarding the errors,

either rename:

resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.4 nozzle.json
resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.6 nozzle.json

to

resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.4 Nozzle.json
resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.6 Nozzle.json

or update resources\profiles\Flashforge.json by changing the following lines:

	{
      "name": "Flashforge Adventurer 3 Series 0.4 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.4 Nozzle.json"
    },
    {
      "name": "Flashforge Adventurer 3 Series 0.6 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.6 Nozzle.json"
    },

to

	{
      "name": "Flashforge Adventurer 3 Series 0.4 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.4 nozzle.json"
    },
    {
      "name": "Flashforge Adventurer 3 Series 0.6 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.6 nozzle.json"
    },

@Bai825
Copy link
Author

Bai825 commented May 24, 2024

@FlashforgeOfficial @Bai825 @FlashForge what about removal of legacy filament files?

Regarding the errors,

either rename:

resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.4 nozzle.json
resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.6 nozzle.json

to

resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.4 Nozzle.json
resources\profiles\Flashforge\machine\Flashforge Adventurer 3 Series 0.6 Nozzle.json

or update resources\profiles\Flashforge.json by changing the following lines:

	{
      "name": "Flashforge Adventurer 3 Series 0.4 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.4 Nozzle.json"
    },
    {
      "name": "Flashforge Adventurer 3 Series 0.6 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.6 Nozzle.json"
    },

to

	{
      "name": "Flashforge Adventurer 3 Series 0.4 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.4 nozzle.json"
    },
    {
      "name": "Flashforge Adventurer 3 Series 0.6 Nozzle",
      "sub_path": "machine/Flashforge Adventurer 3 Series 0.6 nozzle.json"
    },

Thanks!
Yes, I was intended to keep all the naming uniform with first letter being capital letter. Somehow I submit the commit, the machine profile name for ad3 were still like Flashforge Adventurer 3 Series 0.4 nozzle.json and Flashforge Adventurer 3 Series 0.6 nozzle.json. I am gonna rewind this part change submit change for other parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants