BUG: Fix warnings when vtkMRMLModelNode has no mesh data #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
May 17, 2024
Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx
Outdated
Show resolved
Hide resolved
Sunderlandkyl
force-pushed
the
null_model_polydata_fix
branch
from
59c162e
to
7033cc8
Compare
Fixes warnings during rendering such as: > Algorithm vtkPassThrough (00000223357FFBC0) returned failure for request: vtkInformation (000002233CEA6520) Fixed by enabling AllowNullInput on the vtkPassThrough in vtkMRMLModelDisplayNode. This commit also fixes an issue where the views would not be immediately rendered when vtkMRMLModelNode::SetAndObserveMesh(nullptr) was called for a model node that previously had a mesh. Fixed by not returning early and accounting for IsModelDisplayable in OnMRMLDisplayableModelNodeModifiedEvent.
Sunderlandkyl
force-pushed
the
null_model_polydata_fix
branch
from
7033cc8
to
f5c60c1
Compare
Sunderlandkyl
commented
May 17, 2024
| continue; | ||
| { | ||
| // Optimization: no need to search any further. | ||
| break; |
There was a problem hiding this comment.
Fixed an issue that I just noticed in IsModelDisplayable. Should be break not continue.
lassoan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings during rendering such as:
Fixed by enabling AllowNullInput on the vtkPassThrough in vtkMRMLModelDisplayNode.
This commit also fixes an issue where the views would not be immediately rendered when vtkMRMLModelNode::SetAndObserveMesh(nullptr) was called for a model node that previously had a mesh. Fixed by requesting a render in vtkMRMLModelDisplayableManager whenever an actor that was previously visible is no longer displayable.