COMP: Fix main project source dir colliding with built-in extension of same name #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyNameApp (Slicer custom app)
MyName.exe (MyNameApp's application name)
MyName (extension name included in custom app)
The following could collide:
${Slicer_MAIN_PROJECT_APPLICATION_NAME}_SOURCE_DIR
${${extension_name}_SOURCE_DIR}
The issue was discovered when MainApplicationRepositoryRevision and MainApplicationRepositoryURL reported info for the extension of same name instead of the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my situation of names utilized for a Slicer custom app, the custom app's application name and the name of an extension packaged into the custom app:
MyNameApp (Slicer custom app) (github.com/MyOrg/MyNameApp)
MyName.exe (MyNameApp's application name)
MyName (extension name included in custom app) (github.com/MyOrg/MyName)
The following could collide:
${Slicer_MAIN_PROJECT_APPLICATION_NAME}_SOURCE_DIR ${${extension_name}_SOURCE_DIR}
The issue was discovered when MainApplicationRepositoryRevision and MainApplicationRepositoryURL reported info for the extension of same name instead of the application.