BUG: Mark translatable strings in Markups module #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
Mar 19, 2024
| @@ -151,6 +151,9 @@ class VTK_SLICER_MARKUPS_MODULE_MRML_EXPORT vtkMRMLMarkupsNode : public vtkMRML | |||
| /// Get markup short name | |||
| virtual const char* GetDefaultNodeNamePrefix() {return "M";}; | |||
|
|
|||
| /// Get markup type GUI display name | |||
| virtual const char* GetTypeDisplayName() override {return this->TypeDisplayName.empty() ? "Markup" : this->TypeDisplayName.c_str();}; | |||
There was a problem hiding this comment.
Move the implementation to the .cxx file and make thd default "Markup" string translatable.
Modules/Loadable/Markups/Widgets/qMRMLMarkupsCurveSettingsWidget.cxx
Outdated
Show resolved
Hide resolved
| @@ -45,8 +45,8 @@ class qMRMLMarkupsCurveSettingsWidgetPrivate | |||
| public: | |||
| qMRMLMarkupsCurveSettingsWidgetPrivate(qMRMLMarkupsCurveSettingsWidget &widget); | |||
|
|
|||
| static const char* getCurveTypeAsHumanReadableString(int curveType); | |||
| static const char* getCostFunctionAsHumanReadableString(int costFunction); | |||
| static std::string getCurveTypeAsHumanReadableString(int curveType); | |||
There was a problem hiding this comment.
To follow Qt conventions
Suggested change
| static std::string getCurveTypeAsHumanReadableString(int curveType); | |
| static QString curveTypeAsDisplayableString(int curveType); |
| static const char* getCurveTypeAsHumanReadableString(int curveType); | ||
| static const char* getCostFunctionAsHumanReadableString(int costFunction); | ||
| static std::string getCurveTypeAsHumanReadableString(int curveType); | ||
| static std::string getCostFunctionAsHumanReadableString(int costFunction); |
There was a problem hiding this comment.
To follow Qt conventions
Suggested change
| static std::string getCostFunctionAsHumanReadableString(int costFunction); | |
| static QString costFunctionAsDisplayableString(int costFunction); |
|
@mhdiop Could you please have a look at the comments and update the pull request accordingly? Thank you! |
|
Thank you @lassoan for the reminder. I'll update and submit it in a few moments. |
mhdiop
force-pushed
the
mark-markups-module
branch
from
bfa3afe
to
2f97a75
Compare
jcfr
reviewed
Apr 23, 2024
| @@ -1029,6 +1032,14 @@ class VTK_SLICER_MARKUPS_MODULE_MRML_EXPORT vtkMRMLMarkupsNode : public vtkMRML | |||
|
|
|||
| std::string PropertiesLabelText; | |||
|
|
|||
| /// Store markup type GUI display name | |||
| /// It's displayed to the user and is therefore translated to the application language | |||
There was a problem hiding this comment.
Suggested change
| /// It's displayed to the user and is therefore translated to the application language | |
| /// \note It's displayed to the user and is therefore translated to the application language |
| std::string TypeDisplayName; | ||
|
|
||
| /// Store markup short name | ||
| /// It's displayed to the user and is therefore translated to the application language |
There was a problem hiding this comment.
Suggested change
| /// It's displayed to the user and is therefore translated to the application language | |
| /// \note It's displayed to the user and is therefore translated to the application language |
Comment on lines
21
to
22
| #include "vtkMRMLI18N.h" | ||
| #include "vtkCurveGenerator.h" | ||
| #include "vtkCurveMeasurementsCalculator.h" |
There was a problem hiding this comment.
Suggested change
| #include "vtkMRMLI18N.h" | |
| #include "vtkCurveGenerator.h" | |
| #include "vtkCurveMeasurementsCalculator.h" | |
| #include "vtkCurveGenerator.h" | |
| #include "vtkCurveMeasurementsCalculator.h" | |
| #include "vtkMRMLI18N.h" |
mhdiop
force-pushed
the
mark-markups-module
branch
from
2f97a75
to
774acf1
Compare
lassoan
force-pushed
the
mark-markups-module
branch
from
774acf1
to
174466e
Compare
lassoan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark some remaining translatable strings in Markups module