Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Avoid floating SH combobox popup by default #7276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

malbi
Copy link

@malbi malbi commented Oct 11, 2023

Align pop-up vertically to combo box can lead to pop-up being rendered outside the limit of the main window.
Here is a proposal to disable it by default and render the pop-up tree below the combo box to be consistent with other combo boxes behavior.

@lassoan
Copy link
Contributor

lassoan commented Oct 12, 2023

To me, it seems that the current default behavior (alignPopupVertically=True) is better for keeping the popup in a reachable location. Could you please provide an example screenshot of a case when alignPopupVertically=False is better than alignPopupVertically=True?

@malbi
Copy link
Author

malbi commented Oct 12, 2023

I create a Combobox just above "Data probe" section in the left part. With alignPopupVertically=true, when selecting an item in a long list and scrolling farther away from this item I got this behavior:
alignPopupVerticallyTrue_1
alignPopupVerticallyTrue_2
alignPopupVerticallyTrue_3

With alignPopupVertically=false, in the same context I got a consistent display of the selection tree:
alignPopupVerticallyFalse_1
alignPopupVerticallyFalse_2
alignPopupVerticallyFalse_3

I did not spent any time to create this combobox in an appropriate location in the Slicer UI, but in our use case, it is located in the upper part of our custom window and having to change the alignVerticallyPopup property for each combobox to not have them floating away from the screen in case of big number of item seems a bit weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants