-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU: Remove unused dynamic state and pipeline settings #6796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minus comment. This is most likely a leftover from when we didn't use dynamic state at all.
d23ef85
to
882bb52
Compare
…cStateCreateInfo as the command to set them is never called. Do not pass pointer to viewport and scissor as those dynamic states should be supported on all devices. Same as above for DepthBias values.
882bb52
to
4edbb36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, though not using depth bounds seems more like we haven't really implemented it on the GPU side. Not that we know of any games to test with it, but it might return in future.
This change likely has no user facing changes, but just need to check if there is anything broken. Just clean-up for future changes.