dxx-rebirth game data #3922
Draft
dxx-rebirth game data #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some dxx rebirth changes in progress including the game data locations. I've already uploaded them to our server I think. I'll try and finish it this week. |
In 77bb4c1 the code was locked to an older commit due to incompatibilities with Raspberry Pi OS Buster, but this version doesn't build with newer GCC. Switch to using the latest code by default but lock to older versions for Buster and GCC 10 and lower Tested to build correctly on Raspberry Pi OS Buster, Bullseye and Bookworm.
Newer dxx-rebirth uses a build/ subfolder.
The official site no longer hosts the files.
|
Please see #3923 I am happy to include your changes minus the shareware data part. I can cherry-pick your commits into my branch if you like or you can open a new PR with them. One thing I would change in your code is to not use 2 find calls and instead do
Thanks for the PR :-) |
So I would open a pull against your branch, then, you mean? |
s1eve-mcdichae1
force-pushed
the
dxx-game-data
branch
from
2a5ad70
to
da0b6f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't download D2 shareware data if registered version files exist.
Ignore case - don't download D1/D2 shareware whether user-provided data files in ALL CAPS (DOS) or lowercase (Steam).
Shareware and add-on files no longer available from dxx-rebirth.com - switch to self-hosted files at
$__archive_url(I don't know how to actually put them there, though. Someone else will have to do that part, or show me how.)