Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added include for static embree library #292

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

pnav
Copy link
Contributor

@pnav pnav commented Dec 21, 2018

Hello,

This pull request adds a small section to ospray_macros.cmake to properly include Embree as a static library if it is built statically. This relies on Embree pull request 227.

This has been verified using OSPRay 1.7.x build.

@jeffamstutz
Copy link
Contributor

I promise this is still on our plate to merge....we've been doing more overhauls to our CMake stuff, including having our libraries respect BUILD_SHARED_LIBS more appropriately. I'll make sure this makes it into v2.0....we haven't been doing anything with v1.8.x for a while now, but it's time we get this incorporated so it doesn't get lost!

@mathstuf
Copy link
Contributor

Why does this need to be predicated on whether embree is static or not? Is just using the embree imported target not good enough?

@pnav
Copy link
Contributor Author

pnav commented Aug 30, 2019

@mathstuf the ospray cmake at the time of this pull request hardcoded libembree.so even when embree was built statically. I understand that the cmake config for ospray has changed considerably in 1.8.x so it might work properly now. My embree static lib fixes have been merged into the embree tree for a while, so the latest there will properly expose the static library for testing with ospray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants