Added didFailProvisionalNavigation to WKWebView+Rx. #2557
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freak4pc
reviewed
Apr 20, 2024
| @@ -52,6 +52,18 @@ extension Reactive where Base: WKWebView { | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| public var didFailProvisionalNavigation: Observable<(WKNavigation, Error)> { | |||
There was a problem hiding this comment.
Please add a corresponding test in WKWebView+Tests.swift
freak4pc
force-pushed
the
main
branch
2 times, most recently
from
1198683
to
5949cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am encountering a significant issue as didFailProvisionalNavigation is missing in
WKWebView+Rx.For more details on this function, please refer to the Apple Developer documentation:
https://developer.apple.com/documentation/webkit/wknavigationdelegate/1455637-webview
I have added this function and would greatly appreciate it if knowledgeable individuals could review it.
Thank you very much in advance for your assistance.