added websocket server #1029
Draft
added websocket server #1029
+601
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this required to refactor some of the code to avoid circular dependencies. as a result the CLI code could be greatly reduced and is now pretty simple * pytaglib was added as requirement, which is now used to keep meta data from the source file and to add meta data with the RVC generation flags to the output file (this could/should probably also be added to batch conversion) * cli interface was made executable so that it can be run from CLI on linux/mac systems
…the original data (which we want to send back as part of the Websocket response)
…ebugging added (optional) incremental file naming if the output file exists already
fumiama
requested changes
Aug 26, 2023
| @@ -70,6 +58,10 @@ def forward_dml(ctx, x, scale): | |||
| mem = [] | |||
| if_gpu_ok = False | |||
|
|
|||
|
|
|||
|
|
|||
| start_websocket_server('127.0.0.1', 15159) | |||
There was a problem hiding this comment.
You can also add this to config and add a commandline parameter to control this.
| @@ -18,26 +18,23 @@ | |||
| from subprocess import Popen | |||
| from time import sleep | |||
|
|
|||
| from src.configuration import * | |||
There was a problem hiding this comment.
It's better to specify all components used but not *.
| import os | ||
| from src.configuration import weight_root | ||
|
|
||
| def get_voice_weights(): |
There was a problem hiding this comment.
maybe this can be put into lib/audio.py
|
yeah, doesn't make sense to make any changes now if the PR is stall anyways and conflicting with the cleanup which is in progress now... I'll eventually come back to this when the cleanup is done. |
|
OK. It won't take a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this required to refactor some of the code to avoid circular dependencies. as a result the CLI code could be greatly reduced and is now pretty simple
websocket server listens by default on localhost:15159 (it's NOT recommended to run the websocket server on a public network/interface, since there's no security checks implemented)
example requests:
process an audio file and save the output to
get a list of available voice weights