feat: rewrite validate_proxy_domains celery task as temporal workflow #22363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
reviewed
May 20, 2024
frontend uses this to update the UI
most should have been schedule_to_close not start to close
frankh
force-pushed
the
frank/create-temporal-work-for-proxy-service
branch
from
90134af
to
cf5940f
Compare
ruff is refusing to ignore these files, can't reproduce locally 🤷
daibhin
approved these changes
May 20, 2024
fuziontech
approved these changes
May 21, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
timgl
pushed a commit
that referenced
this pull request
May 24, 2024
…#22363) * rewrite validate_proxy_domains celery task as temporal workflow * Fix styling * Create workflow * Formatting * Fix typing for workflow * Ignore proto import typechecking * Add type files * comment * Add proxy gRPC address * return serialized response from create frontend uses this to update the UI * Fix timeouts most should have been schedule_to_close not start to close * Error state * fix formatting ruff is refusing to ignore these files, can't reproduce locally 🤷 * Fix erroring type * remove old proxy celery task * Add delete workflow * Add missing import * Fix proxy workflows not being registered to worker * Add missing workflow method * fix serialization error and wait for dns * fix delete sync_to_async typing issue * Switch from batch exports queue to new "general-purpose" queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Towards https://github.com/PostHog/product-internal/issues/602
bonus: now using gRPC instead of http
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?