bugfix: convert several providers stop_reason to valid openai finish_reason #363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, we forward the anthropic
stop_reason
, which is not compatible with the openaifinish_reason
.This can cause warnings from some OpenAI sdk.
The conversion function returns
stop
as a default value in case newstop_reason
are added.There was also a bug in the groq and google providers for the
finish_reason
Side note:
It would probably be beneficial to update the types to we can get compilation-time validation :
gateway/src/providers/types.ts
Lines 101 to 123 in 77f32e5
Proposed change :
see https://platform.openai.com/docs/guides/text-generation/chat-completions-response-format