Test hidden visibility default on gcc #5779
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
force-pushed
the
gcc_hidden_visibility
branch
9 times, most recently
from
dd32d31
to
4276c3a
Compare
mvieth
force-pushed
the
gcc_hidden_visibility
branch
from
4276c3a
to
9b1508d
Compare
mvieth
force-pushed
the
gcc_hidden_visibility
branch
6 times, most recently
from
eaab75c
to
a8517d7
Compare
mvieth
force-pushed
the
gcc_hidden_visibility
branch
from
a8517d7
to
cb713cc
Compare
|
This would close #1913 FYI. |
mvieth
force-pushed
the
gcc_hidden_visibility
branch
2 times, most recently
from
f6767fb
to
9f734b2
Compare
Osyotr
reviewed
Jan 24, 2024
| @@ -121,6 +121,9 @@ if(CMAKE_COMPILER_IS_GNUCXX) | |||
| endif() | |||
| string(APPEND CMAKE_CXX_FLAGS " -Wall -Wextra -fno-strict-aliasing ${SSE_FLAGS} ${AVX_FLAGS}") | |||
| endif() | |||
| if(PCL_SYMBOL_VISIBILITY_HIDDEN) | |||
| string(APPEND CMAKE_CXX_FLAGS " -fvisibility=hidden -fvisibility-inlines-hidden") | |||
There was a problem hiding this comment.
Consider setting these flags globally. CMake will figure out right options to pass to compilers.
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)There was a problem hiding this comment.
Thanks for the suggestion, I will take a look at those CMake options when I find the time to continue this pull request.
mvieth
added
the
changelog: new feature
mvieth
force-pushed
the
gcc_hidden_visibility
branch
2 times, most recently
from
16e3e28
to
572c341
Compare
mvieth
force-pushed
the
gcc_hidden_visibility
branch
2 times, most recently
from
0e1c5a9
to
79cc27b
Compare
mvieth
force-pushed
the
gcc_hidden_visibility
branch
from
79cc27b
to
c2442d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.