Move outofcore tools to tools folder. #5606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
reviewed
Feb 23, 2023
|
|
||
| if(TARGET pcl_visualization) | ||
| set(srcs outofcore_viewer.cpp | ||
| ../outofcore/src/visualization/camera.cpp |
There was a problem hiding this comment.
I don't like the idea of using/referring to files in another PCL module. However, it seems like the files in outofcore/src/visualization are only used by the outofcore_viewer, and not compiled into the outofcore module library? But on the other hand, the corresponding headers in outofcore/include/pcl/outofcore/visualization are installed as if the outofcore module library contained all the stuff from the cpp files? Unfortunately I don't have any experience with outofcore, so no idea how it is supposed to be.
Moving pcl_outofcore_process and pcl_outofcore_print seems unproblematic, so that's fine by me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.