Fix #21418: Cannot place scenery high #21420
Conversation
tupaschoal
changed the title
|
Does anyone know the reason it was originally set to 32 below? |
|
I am desperately waiting on this feature. Just thought the devs should know ❤️ |
| @@ -1700,7 +1700,7 @@ class TopToolbar final : public Window | |||
|
|
|||
| auto screenPos = sourceScreenPos; | |||
| uint16_t maxPossibleHeight = ZoomLevel::max().ApplyTo( | |||
| std::numeric_limits<decltype(TileElement::BaseHeight)>::max() - 32); | |||
| std::numeric_limits<decltype(TileElement::BaseHeight)>::max() - 1); | |||
There was a problem hiding this comment.
Is this subtraction really necessary? The scenery entry's height is already subtracted a few lines down. I guess it may still be needed because IIRC the max base height is a way the game marks elements to be removed. Not sure if that's still the case.
There was a problem hiding this comment.
Do you mean the -1, or the -32?
I thought I had already commented on this, but I don't any comment of mine anywhere.
The -32 is not needed, the -1 is, without it if you place something at the top level, I'm not even sure exactly what happens, but not what you'd want.
|
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
please implement this soon |
For #21418
Change the limits for small scenery and walls only.
Multi-piece large scenery could cause problems and be placed incomplete.