Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates from issues and pull requests #366

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

aviral-batra
Copy link

I have implemented a few issues and enhancements that were requested and that I would like:

the ability to

  • ignore files for the scan using the code from this pull request
  • use folders as decks if no other deck is given i.e. from the target deck line or folder deck (hierarchically so you don't have to do it)
  • rescan files with notes that are not added as an error so a) you keep seeing the error and it is not lost in the depths of notes and b) to see if the error is fixed on rescan e.g. if the deck for the note now exists

These have all been added as optional settings so it won't change the current behavior of the plugin.

@aviral-batra
Copy link
Author

I also updated the format of the build process to match the current obsidian sample plugin more.

@aviral-batra
Copy link
Author

Also, I deleted the python files on my repo to make it cleaner for me to work with so you may want to ignore those changes.

@aviral-batra
Copy link
Author

aviral-batra commented Mar 24, 2023

Hi, I noticed you had come back. I haven't used obsidian to anki in a while but I fixed most of the issues a while ago that were in pull requests and some that I personally had. You can take a look if it helps.

@aviral-batra
Copy link
Author

@Pseudonium

@shoudeyunkaijianyueming

Hello brother, I raised some questions in the obsidian to anki you modified. I hope brother can modify it. You modified the latest version of obsidain, and the plugin cannot be synchronized.

@aviral-batra

@shoudeyunkaijianyueming

I found that the two great gods are modifying obsidian to anki, and it is the best two versions during my use. Why don't you two brothers communicate and cooperate? Hahaha, please ignore if you are disturbed.

@aviral-batra
@ShootingKing-AM

@ShootingKing-AM
Copy link
Member

ShootingKing-AM commented Jan 10, 2024

Can you rebase this PR to latest master. Interesting features were added. Also, you seem to like used ESBuild config instead of rollup.
can you separate ESBuild config into a different PR? Also, Dont delete Python files, dont change version, add some tests, dont add other PR's code into this PR, will merge the other PR by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Folder settings - additional default options
3 participants