add some convenience for shell-users #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccwienk
commented
Jan 6, 2022
ccwienk
commented
- set executable bit (so shebang is actually honoured on UNIX-style OSs
- calculate paths relative to main.py (do not depend on PWD)
NetroScript
reviewed
Jan 9, 2022
|
Didn't think anyone would be using it outside as a tool from the current folder. Changes perfectly fine with me, besides the one thing I commented on. So I am just waiting for your response before merging. |
Avoid requiring that PWD be set to repository root. Instead, determine own directory, and calculate resource file paths relative to it.
|
@NetroScript : I removed the left-over. Note however, that this change is unfortunately not complete; the http-server would also need to be adjusted to not server from PWD
yeah, it is a habbit of mine to both run basically everything from terminal, and also use different PWDs to find scripts that do not properly handle this case :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.