Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send "Unmute" on volume change #1465

Closed
wants to merge 4 commits into from

Conversation

zv0n
Copy link

@zv0n zv0n commented Nov 8, 2023

My monitor requires sending "Unmute" command over DDC after a volume change for that change to take effect.

I've added an option into the UI to enable this behavior.

Might fix problems for some people in this issue - #1369

@dimaqq
Copy link

dimaqq commented Dec 18, 2023

My 2c, as an end user: the setting may be somewhat confusing.
If it's only a single monitor that needs this hack, I would consider following:

  1. check if monitor firmware can be updated
  2. ask on mastodon/reddit/twitter to see if monitors of other models / from other manufacturers need this
  3. add some kind of clarification, e.g. send unmute on volume change (fixes Macintosh 512K display) or a url link to github issue where folks can report their monitors

@LiWinDom LiWinDom mentioned this pull request May 16, 2024
3 tasks
@max-degterev
Copy link

max-degterev commented Jun 4, 2024

I'm having an issue where after muting os doesn't unmute displays until full restart. hopefully fixes my issue too, would be cool to test a build. running 27UK850 over USB-C

@waydabber
Copy link
Member

@zv0n - I'll close this PR as honestly I am somewhat undecided whether to add it or not. Also, there is no new app release planned anytime soon. However it is clear that this change is useful to some, so I recommend having a fork with this available and maybe provide an alternate build in your repo + open a discussion with a link over there about it in this repo. I can pin the discussion so it does not get lost. Does that sound fair?

@waydabber waydabber closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants