Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Server doesn't stop when using
MinecraftServer#stopCleanly
inside a commandResolves #2096
Why this bug happens ?
During the server lifecycle commands are executed in
connection().tick(msTime)
(ServerProcessImpl.TickerImpl
class)When you use the /shutdown command,
MinecraftServer#stopCleanly
method is called which stops allTickThread
After all commands are executed,
serverTick(msTime)
is called which start (stopped TickThread) and wait until threads are finishedSolution: set a flag to true when stop method is called and check this flag at end of tick