Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.5 #2089

Open
wants to merge 93 commits into
base: master
Choose a base branch
from
Open

1.20.5 #2089

wants to merge 93 commits into from

Conversation

mworzala
Copy link
Member

@mworzala mworzala commented Apr 10, 2024

Work in progress 1.20.5 branch. All of the item components have a (largely untested) implementation and most functionality seems to be there for items and other packet changes.

This branch also includes the following:

Immediately pressing issues:

  • Tests needed for the component implementations
  • Dynamic registries all need to be changed to work more like Biome, as well as load the vanilla data and track modifications to decide what data to send (new known packs exchange).

Transfer Packet:

  • I am aiming to finish and merge this branch without support for transfer packets. This will come in a future update.

Backwards compatibility/upgrading:

  • Currently no backwards compatibility is maintained in this branch. I could make the item component changes backwards compatible, however I don't believe it's worth the effort. There are significant other changes here which are non backwards compatible.
  • I will be writing an upgrade guide for this version bump.

This branch is now published on Maven Central at net.minestom:minestom-snapshots:1_20_5-{first 10 chars of a commit hash}

@mworzala
Copy link
Member Author

I rebased on top of the inventory PR, though it is quite a messy state right now. There is a circular reference that I'm not totally sure how to resolve.

ItemStack.AIR -> Initializes Material -> Initialized Registry.MaterialEntry -> Initializes ItemComponentMap -> Initializes ItemComponent -> ItemComponent.CHARGED_PROJECTILES has a List which initializes ItemStack.

@mworzala
Copy link
Member Author

(its not actually ready for review, I just want the ci jobs to run)

@mworzala mworzala force-pushed the 1_20_5 branch 2 times, most recently from c182805 to c29fe5a Compare April 25, 2024 12:45
@mworzala mworzala force-pushed the 1_20_5 branch 2 times, most recently from b938dad to d622462 Compare April 30, 2024 03:59
@mworzala mworzala force-pushed the 1_20_5 branch 2 times, most recently from e2d8d1e to 323c75f Compare May 5, 2024 17:50
@mworzala
Copy link
Member Author

mworzala commented May 18, 2024

The latest commit here is (intentionally) not building. If you want to use this branch, use net.minestom:minestom-snapshots:1_20_5-323c75f8a5.

Ignore, use latest.

mworzala and others added 29 commits June 2, 2024 07:42
… Preemptively diff with material prototype when constructing itemstack
* feat: LivingEntity fire overhaul

* chore: missed method change
…instance (#2062)

* feat: world border overhaul, turned into a record and handled by instance

* chore: replace WorldBorder#defaultBorder() with a DEFAULT_BORDER constant
* pathfinding

* mutablepoint fix in player
Fix build error

Move item usage completed to a different event

Add a way to check if the item usage has completed, or is aborted by the player

Only process animation when the item use time is not instant

Update javadoc

Re-add Player#isEating

Remove deprecated Player#callItemUpdateStateEvent

Allow specifying item usage duration inside PlayerUseItemEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants