Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify test mocking #24589

Closed
wants to merge 1 commit into from
Closed

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 17, 2024

No description provided.

@danjm danjm requested a review from a team as a code owner May 17, 2024 13:31
@danjm danjm marked this pull request as draft May 17, 2024 13:31
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [cf6bcc6]
Page Load Metrics (764 ± 513 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63189882713
domContentLoaded96315136
load5128007641068513
domInteractive96315136
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 6.58 KiB (0.10%)
  • common: -1007 Bytes (-0.02%)

@danjm
Copy link
Contributor Author

danjm commented May 21, 2024

this has been accounted for in the upstream PR #24041

@danjm danjm closed this May 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants