Added Priority in Broken Rule #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-rule-in-the-BrokenRuleType/main
…he-rule-in-the-BrokenRuleType/main
StefanOssendorf
requested changes
May 18, 2024
…he-rule-in-the-BrokenRuleType/main
StefanOssendorf
approved these changes
May 20, 2024
There was a problem hiding this comment.
@rockfordlhotka The changes are okay for me. But please double check if it's what was intended with the associated issue. Thanks
rockfordlhotka
requested changes
May 20, 2024
|
I added the BreakingChange tag to the original issue, as this does change the behavior of existing methods. Beyond my one request for a potential code change, I like the changes being made here. |
…he-rule-in-the-BrokenRuleType/main
Is this any changes required here? If not Can you please merge this PR? |
…he-rule-in-the-BrokenRuleType/main
|
@rockfordlhotka Please approv so lgtm :) |
rockfordlhotka
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Updated 'GetFirstBrokenRules()' in BrokenRulesCollection, this method will return 'first' broken rules for the object (or object graph).
-Added Priority to
BrokenRule.csFixes #3224