Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash possibility if module: <name> is not defined and on mistake position: <position> #3445

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

bugsounet
Copy link
Contributor

Fix #3442

@bugsounet bugsounet marked this pull request as draft May 10, 2024 12:28
@KristjanESPERANTO
Copy link
Contributor

Just a thought: Wouldn't that be a thing that belongs in check_config.js?

@sdetweil
Copy link
Collaborator

yes, also.

@bugsounet
Copy link
Contributor Author

check_config.js check only syntax but it does not check the contents of the file

should we make some other checks on it too ?

@sdetweil
Copy link
Collaborator

sdetweil commented May 13, 2024

well, this one is the first actual content that is important..
altho position should be checked too.. at least valid if specified.. that is another crash..

the user that reporteds the split problem said they ran config:check but it was good..

@bugsounet
Copy link
Contributor Author

bugsounet commented May 13, 2024

So, we have to check module: <name>and position: <valid position> (if defined)

we check it on check_config.js and MM core ?

Personally, I think it's essential to apply the rules to both

@sdetweil
Copy link
Collaborator

I think so.. never crash..

@bugsounet
Copy link
Contributor Author

ok, I will see to code it

@bugsounet
Copy link
Contributor Author

Right, I will try to add needed rules with eslint in check_config.js ;)

I have never done this kind of test.
bugsounet, it's time to learn :)

@bugsounet
Copy link
Contributor Author

bugsounet commented May 18, 2024

module name error:
image

position error:
image

No error:
image

I'm not sure that i can integrate it into eslint

What do you think @sdetweil ?

@bugsounet bugsounet changed the title Fix crash possibility if module: <name> is not defined Fix crash possibility if module: <name> is not defined and on mistake position: <position> May 18, 2024
@bugsounet bugsounet marked this pull request as ready for review May 26, 2024 09:16
@bugsounet
Copy link
Contributor Author

Before approuve some new deps.
Thanks to review this :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants