Try to ensure that entities get a reasonable (i.e. non-zero) Z scale. #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While LibreCAD ignores Z scale on input, generating DXF with entities that has a Z scale of zero creates problems for others. FreeCAD will for instance choke. An alternative way of dealing with this would be omitting writing Z scales (record 43) to the DXF in the first place.
lordofbikes
added
PR small
lordofbikes
added
PR next release
lordofbikes
reviewed
Jun 6, 2022
| @@ -316,6 +316,7 @@ void Plugin_Entity::getData(QHash<int, QVariant> *data){ | |||
| data->insert(DPI::STARTANGLE, d.angle ); | |||
| data->insert(DPI::XSCALE, d.scaleFactor.x ); | |||
| data->insert(DPI::YSCALE, d.scaleFactor.y ); | |||
| data->insert(1.0, d.scaleFactor.z ); | |||
There was a problem hiding this comment.
This should at least be data->insert(DPI::ZSCALE, d.scaleFactor.z );
|
The comment in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While LibreCAD ignores Z scale on input, generating DXF with entities that has a Z scale of zero creates problems for others.
FreeCAD will for instance choke, see https://tracker.freecadweb.org/view.php?id=4791
An alternative way of dealing with this would be omitting writing Z scales (record 43) to the DXF in the first place.
This is a proposed fix for #1428