[Proposal] Add some PEP 484 type checking via pytype #187
Conversation
With it the docimentation can refer to type annotations. See https://github.com/agronholm/sphinx-autodoc-typehints
module. Note thanks to sphinx-autodoc-typehints added in previous commit this should not reduce the quality of the generated documentation.
|
Hi! Thanks for the pull request. We’re not sure about what the future of cairocffi will be. We (CourtBouillon, the current maintainer) are about to drop Cairo from WeasyPrint dependencies (Kozea/WeasyPrint#1232), and we’ll soon decide what is better for the future of cairocffi. Until then, we don’t really want to change the way the library works, and we prefer to keep the status quo. |
|
Makes sense, thank you! I'll leave this PR hanging here until you decide what to do or until there's a new maintainer. (or feel free to close if that's what you prefer - no hard feelings). I've also noticed I missed one flake8 error; won't fix it for now but if you or anyone else wants to resurrect this PR just ping me here. |
|
We’ve decided that we’ll keep maintaining the library but won’t add new features, and we personally don’t like type annotations very much, so we won’t merge this pull request. We hope that it’s not blocking for what you do with CairoCFFI 🤞🏽. |
There is no particularly strong reason to do this, but it adds one more static analysis tool.
See https://github.com/google/pytype
Note it is currently not enforced as there is no pytest integration (see google/pytype#422). It is relatively easy to add pytype check to github workflow. But I suppose it may become annoying without client-side integration with test suite (i.e. people will sent PRs after running tests only to discover pytype fails for whatever reason).