Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement form fields #1018

Closed
wants to merge 33 commits into from
Closed

Implement form fields #1018

wants to merge 33 commits into from

Conversation

liZe
Copy link
Member

@liZe liZe commented Dec 31, 2019 •
edited

Includes commits from @Afoucaul’s #985, fixes #61.

We have a lot of work:

  • Allow users to type something else than ASCII characters.
  • Use the real font used for the input rendering.
  • Allow users not to include PDF inputs, using a CLI/API option.
  • Handle more input types (and don’t crash when meeting an unknown one).
  • Add tests (of course!).

Afoucaul and others added 28 commits October 28, 2019 10:39
@Afoucaul
Write roadmap
8ee4662
@Afoucaul
Create forms submodule and begin augment_markup
658e6e8
@Afoucaul
Write markup augmentation
5c7a428
@Afoucaul
Call markup augmentation
c12ef82
@Afoucaul
Update roadmap
f00bc40
@Afoucaul
Create wf stylesheet
99dcdb4
@Afoucaul
Include wf stylesheet at render
f31c4e9
@Afoucaul
Update roadmap
f14363c
@Afoucaul
Collect wfids from generated pdf
6596ccb
@Afoucaul
Update roadmap
8902d36
@Afoucaul
Parse HTML class as well
927758e
@Afoucaul
Prepare conversion WField -> PDF obj
c7ce308
@Afoucaul
Make PDF objects for form fields
4e07ce0
@Afoucaul
Build form and attach it to root
d80361a
@Afoucaul
Add annotations to page elements
866e3da
@Afoucaul
Delete dead code
0023a7e
@Afoucaul
Call form function from pdf
f0e0675
@Afoucaul
Attach annotations to page objects
f6bcb8e
@Afoucaul
Update roadmap
4666932
@Afoucaul
Add items to roadmap
0659314
@Afoucaul
Update roadmap
b8326ce
@Afoucaul
Fix annotations populating
373685c
@Afoucaul
Add support for wf-textarea tags
a59c469
@Afoucaul
Remove useless 'pass'
3f4198e
@Afoucaul
Delete roadmap
7bd2e10
@liZe
Merge branch 'armand/forms' of https://github.com/Afoucaul/WeasyPrint …
a01bc57 
…into Afoucaul-armand/forms
@liZe
Fix lint and minor code changes
6e71772
@liZe
Insert form fields in standard metadata function
8f8632e
@liZe liZe added this to the 52 milestone Dec 31, 2019
@liZe liZe added the feature New feature that should be supported label Dec 31, 2019
@liZe liZe mentioned this pull request Dec 31, 2019
Closed
@liZe
Copy link
Member Author

liZe commented Jan 1, 2020

The ASCII limitation and the font are probably the same problem.

@liZe
Copy link
Member Author

liZe commented Apr 4, 2020

I’m not sure that I can find a simple solution without using something different from Cairo :/.

@liZe liZe removed this from the 52 milestone Apr 4, 2020
@Afoucaul
Copy link

Afoucaul commented Apr 4, 2020

You mean, regarding the ASCII characters and the font face?

@liZe
Copy link
Member Author

liZe commented Apr 5, 2020

You mean, regarding the ASCII characters and the font face?

Yes. We probably would have to change the way fonts are included in the PDF, and I suppose that it’s really hard to do this only with a PDF post-processor.

@liZe liZe marked this pull request as draft May 21, 2020 16:10
@liZe liZe mentioned this pull request Jul 24, 2020
Closed
@liZe
Copy link
Member Author

liZe commented Nov 23, 2020

This feature will be added without Cairo (see #1232). A lot of code will need to be changed, I’m closing this issue, but we’ll for sure get some code from this PR 😉.

@liZe liZe closed this Nov 23, 2020
@liZe liZe deleted the forms branch January 13, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature that should be supported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form/Form Fields
2 participants
@liZe @Afoucaul