Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: add support for GRPCRoute #5776

Merged
merged 11 commits into from
Jun 6, 2024
Merged

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Mar 28, 2024

What this PR does / why we need it:

Which issue this PR fixes:

part of: #5705

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tao12345666333 tao12345666333 added the kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API label Mar 28, 2024
@tao12345666333
Copy link
Member Author

tao12345666333 commented Mar 28, 2024

  --- FAIL: TestGatewayConformance/GRPCExactMethodMatching (0.07s)
        --- PASS: TestGatewayConformance/GRPCExactMethodMatching/2_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/EchoThree'_should_receive_a_Unimplemented_(12) (0.01s)
        --- FAIL: TestGatewayConformance/GRPCExactMethodMatching/0_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCExactMethodMatching/1_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/EchoTwo'_should_go_to_grpc-infra-backend-v2 (30.00s)
    --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching (0.06s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/1_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Version:two}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/7_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:green}'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/8_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:red}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/9_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:yellow}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- PASS: TestGatewayConformance/GRPCRouteHeaderMatching/10_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:purple}'_should_receive_a_Unimplemented_(12) (0.01s)
        --- PASS: TestGatewayConformance/GRPCRouteHeaderMatching/4_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:orange}'_should_receive_a_Unimplemented_(12) (0.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/6_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:blue}'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/3_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:blue,Version:two}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- PASS: TestGatewayConformance/GRPCRouteHeaderMatching/5_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Some-Other-Header:one}'_should_receive_a_Unimplemented_(12) (0.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/2_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:orange,Version:two}'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/0_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Version:one}'_should_go_to_grpc-infra-backend-v1 (30.00s)
    --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching (1.29s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/1_request_to_'foo.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/3_request_to_'boo.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/7_request_to_'no.matching.host/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_receive_a_Unimplemented_(12) (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/5_request_to_'multiple.prefixes.foo.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/6_request_to_'foo.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_receive_a_Unimplemented_(12) (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/4_request_to_'multiple.prefixes.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/0_request_to_'bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/2_request_to_'baz.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)

most of these tests have failed.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.2%. Comparing base (8a88685) to head (9455464).
Report is 5 commits behind head on main.

Current head 9455464 differs from pull request most recent head f9e0ed5

Please upload reports for the commit f9e0ed5 to get more accurate results.

Files Patch % Lines
...nternal/controllers/gateway/route_parent_status.go 0.0% 5 Missing ⚠️
...ternal/dataplane/translator/translate_grpcroute.go 66.6% 1 Missing and 1 partial ⚠️
...ternal/controllers/gateway/grpcroute_controller.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5776     +/-   ##
=======================================
- Coverage   73.8%   73.2%   -0.7%     
=======================================
  Files        197     198      +1     
  Lines      19382   19752    +370     
=======================================
+ Hits       14314   14459    +145     
- Misses      4085    4301    +216     
- Partials     983     992      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tao12345666333
Copy link
Member Author

Blocked by #5918

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member Author

For TEST_KONG_ROUTER_FLAVOR=traditional_compatible make test.conformance, there is a failed case here.

        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/3_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:blue,Version:two}'_should_go_to_grpc-infra-backend-v2 (30.00s)

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. some minor comments

test/conformance/suite_test.go Show resolved Hide resolved
test/consts.go Outdated Show resolved Hide resolved
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
programmer04
programmer04 previously approved these changes May 23, 2024
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check whether docs need any updates with the current Kong Gateway this caveat may not be true as discussed on Slack

@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label May 31, 2024
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mentions that it fixes #5705 but that issue also has an AC to add documentation for GRPC and GRPCS backends.

I'd suggest to remove this note so that we don't close #5705 until the docs are changed to provide manuals for those. If those exists somewhere (I'm not sure) then that should ideally be linked in #5705.

Let me know WDYT.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
internal/dataplane/translator/translate_grpcroute.go Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Show resolved Hide resolved
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 enabled auto-merge (squash) June 6, 2024 07:04
randmonkey
randmonkey previously approved these changes Jun 6, 2024
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
@tao12345666333 tao12345666333 merged commit fc74077 into main Jun 6, 2024
38 checks passed
@tao12345666333 tao12345666333 deleted the grpcroute-conformance branch June 6, 2024 09:56
@pmalek pmalek mentioned this pull request Jun 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants