Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Dataplex Aspect Type resource. #10741

Conversation

avijain25
Copy link
Contributor

Adding Terraform support for a Dataplex Aspect Type resource.
Tracking issue: hashicorp/terraform-provider-google#18147

`google_dataplex_aspect_type`

@avijain25 avijain25 marked this pull request as draft May 20, 2024 12:27
@avijain25 avijain25 marked this pull request as ready for review May 20, 2024 12:28
@github-actions github-actions bot requested a review from roaks3 May 20, 2024 12:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@avijain25 avijain25 marked this pull request as draft May 20, 2024 12:28
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1767 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1767 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 489 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_aspect_type (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type" "primary" {
  metadata_template = # value needed
}

Resource: google_dataplex_aspect_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_aspect_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 26
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • dataplex

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample|TestAccDataplexAspectType_dataplexAspectTypeFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexAspectTypeIamBindingGenerated[Error message] [Debug log]
TestAccDataplexAspectTypeIamMemberGenerated[Error message] [Debug log]
TestAccDataplexAspectTypeIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexAspectType_dataplexAspectTypeBasicExample[Error message] [Debug log]
TestAccDataplexAspectType_dataplexAspectTypeFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1767 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1767 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 489 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_aspect_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_aspect_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 26
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • dataplex

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample|TestAccDataplexAspectType_dataplexAspectTypeFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexAspectType_dataplexAspectTypeFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexAspectTypeIamBindingGenerated[Error message] [Debug log]
TestAccDataplexAspectTypeIamMemberGenerated[Error message] [Debug log]
TestAccDataplexAspectTypeIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexAspectType_dataplexAspectTypeBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1956 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1956 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 489 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_aspect_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_aspect_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 27
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • dataplex

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexAspectTypeIamBindingGenerated[Error message] [Debug log]
TestAccDataplexAspectTypeIamMemberGenerated[Error message] [Debug log]
TestAccDataplexAspectTypeIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexAspectType_dataplexAspectTypeBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 2164 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 2164 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 489 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_aspect_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_aspect_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 26
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • dataplex

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample|TestAccDataplexAspectType_dataplexAspectTypeFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexAspectTypeIamBindingGenerated[Debug log]
TestAccDataplexAspectTypeIamMemberGenerated[Debug log]
TestAccDataplexAspectTypeIamPolicyGenerated[Debug log]
TestAccDataplexAspectType_dataplexAspectTypeBasicExample[Debug log]
TestAccDataplexAspectType_dataplexAspectTypeFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2392 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 2392 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 489 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_aspect_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_aspect_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexAspectType_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexAspectType_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@avijain25 avijain25 marked this pull request as ready for review May 20, 2024 19:28
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a few nits, and the test should be changed

mmv1/products/dataplex/AspectType.yaml Show resolved Hide resolved
mmv1/products/dataplex/AspectType.yaml Outdated Show resolved Hide resolved
mmv1/products/dataplex/AspectType.yaml Show resolved Hide resolved
delimaneto and others added 22 commits May 21, 2024 10:03
…uration feature on Beta (GoogleCloudPlatform#10683)

Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: pweiber <periclesweiber@ciandt.com>
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2288 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 2288 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 489 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_aspect_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_aspect_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_aspect_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexAspectType_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexAspectType_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@roaks3
Copy link
Contributor

roaks3 commented May 21, 2024

Closing in favor of #10751

@roaks3 roaks3 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet